Preparation of salts